feat: Optionally require S2S auth for the server /version endpoint#49
feat: Optionally require S2S auth for the server /version endpoint#49jason-famedly wants to merge 1 commit intomasterfrom
Conversation
jason-famedly
force-pushed
the
jason/auth-fed-version
branch
from
926caab to
05c7b71
Compare
|
This looks good to me 💯, but 2 questions, do we need to align with other team about the version that contains this change? |
Aligning with other teams, I suppose not? This change was a request made by gematik, but with zero clear use cases beyond obfuscating exactly which version of the homeserver(and it's branding/model/etc) is currently being run. As such, this work is complete but seems rather unnecessary and will just sit here for a time on the back burner of the stove 😆 |
Adds a new setting that defaults to 'False' for root level yaml configuration `require_auth_for_server_version`: boolean
jason-famedly
force-pushed
the
jason/auth-fed-version
branch
from
05c7b71 to
134bbcf
Compare
2 participants
Fixes: famedly/product-management (need a number)
Adds a new configuration setting possibility:
truewill mean no random people will be able to see what version a server is running without using a federation approved authentication. Defaults tofalseNotes to consider: Famedly employees typically check that a server is online and responsive by checking this endpoint. This will no longer be viable. The client version of this end point is a potential work around. If a server endpoint is needed(due to workers or something) it may be possible to use the server keys endpoint instead